Add Trusted Platform Module (TPM) support

[rhjyoung]

Add Trusted Platform Module (TPM) support

Signed-off-by: Jerone Young jyoung@redhat.com

[ekohl]

These are just my first impressions. Haven't done actual testing on it.

[ekohl]

I'd normally keep the options at the end and even consider the following

Suggested change

	def initialize(attributes = {}, arch = "")
	def initialize(arch, **attributes)

[rhjyoung]

Can definitely move the order. But using **attributes breaks with the convention used in network.rb. Also Trying to change to ** attributes breaks the code.

[rhjyoung]

Created code for Foreman:
theforeman/foreman#10824

[ekohl]

Code looks good to me. A quick test in tests/libvirt/models/compute/server_tests.rb tells me it works. I used this test:

test("with tpm set to true") do
  server = Fog::Libvirt::Compute::Server.new(
    {
      :tpm => true,
      :nics => [],
      :volumes => []
    }
  )
  xml = server.to_xml

  xml.include?('<tpm model="tpm-crb">') && xml.include?('<backend type="emulator" version="2.0"/>')
end

Then get the following XML:

<tpm model="tpm-crb">
  <backend type="emulator" version="2.0"/>
</tpm>

Is this what you'd expect?

[rhjyoung]

Yeap for x86_64 that is the expected result.

[rhjyoung]

Anything else required for this to be merged ?