Skip to content

6 private bucket#20

Open
kevivmatrix wants to merge 5 commits intofog:masterfrom
inkoop:6-private-bucket
Open

6 private bucket#20
kevivmatrix wants to merge 5 commits intofog:masterfrom
inkoop:6-private-bucket

Conversation

@kevivmatrix
Copy link
Copy Markdown

Fixes #6

@kevivmatrix kevivmatrix requested a review from Paxa February 21, 2020 13:01
@philister
Copy link
Copy Markdown

A useful PR! Thanks for that work!

Looks good for me and works with our carrierwave.

Things, I would implement once this PR is merged (I dont know how to create PR which is based on another PR):

Arguments expires and options for url()
https://github.com/inkoop/fog-backblaze/blob/6-private-bucket/lib/fog/backblaze/storage/models/file.rb#L56
As in https://github.com/fog/fog-aws/blame/8185a56f25b12746669e869f72d8e9207a77aa08/lib/fog/aws/models/storage/file.rb#L240
I will implement expires and options[:b2ContentDisposition]

The "default" expiry is imo too long for a private bucket:

validDurationInSeconds: 604800
)

I also noticed, public_url should be nil, if bucket is private, as in fog-aws: https://github.com/fog/fog-aws/blame/8185a56f25b12746669e869f72d8e9207a77aa08/lib/fog/aws/models/storage/file.rb#L170

@kevivmatrix
Copy link
Copy Markdown
Author

@philister Great! I hope it gets reviewed and merged soon.

@Paxa
Copy link
Copy Markdown
Collaborator

Paxa commented Jun 13, 2020

Thank you so much! I will need some time to review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Private fog setting with carrierwave doesn't return URL

3 participants