Set content length to 0 for initial multipart upload call #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-storage-blob 1.1.0 expects either content length to be set or the "body" object to respond to `size`; since `multipart_save_block_blob` passes a nil body to `create_block_blob`, we must set the content length. Co-authored-by: Tom Viehman <tviehman@pivotal.io> Co-authored-by: Seth Boyles <sboyles@pivotal.io>
Contributor
Author
geemus
approved these changes
Feb 18, 2022
Member
geemus
left a comment
geemus
left a comment
There was a problem hiding this comment.
LGTM, thanks. Hopefully we will see some movement on that other PR soon so we can bring this all together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-storage-blob 1.1.0 expects either content length to be set or the
"body" object to respond to
size; sincemultipart_save_block_blobpasses a nil body to
create_block_blob, we must set the contentlength.
Co-authored-by: Tom Viehman tviehman@pivotal.io
Co-authored-by: Seth Boyles sboyles@pivotal.io