feat: add mercenary den notifications#4
Merged
greg2010 merged 1 commit intofnt-eve:mainfrom Mar 6, 2026
Merged
Conversation
Contributor
|
LGTM |
Contributor
Author
Thank you! BTW. Any plans to promote the version of the library ? A 0.0.x version usually represents a prototype. But this library already has a lot of features and seams to be stable enough to use in other projects. I would suggest to go to 0.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would suggest to add two structs for decoding mercenary den notifications. I also includes tests for both.