Ops 188 dont fail on no user secret#26
Open
fairchild wants to merge 7 commits intofnichol:masterfrom
att-innovate:OPS-188-dont_fail_on_no_user_secret
Open
Ops 188 dont fail on no user secret#26fairchild wants to merge 7 commits intofnichol:masterfrom att-innovate:OPS-188-dont_fail_on_no_user_secret
fairchild wants to merge 7 commits intofnichol:masterfrom
att-innovate:OPS-188-dont_fail_on_no_user_secret
Conversation
…user data bag options.
…word instead of disabled account. ('*' vs. 'git status' respectively). This allows pub/private key login.
do not fail when dot files fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an attribute that must be set to true for fetching user_secrets.
Most users dont have secrets, and all the failed attempts slow down the runs, and it feels wrong for default behavior to generate a bunch of 404s.
I also made default behavior of the sync ignore_failure so that one users bad repo, or repo without a pviate key available would not halt the chef run (as it was)
this pull has extra files in it than just these changesdue to merging master in.
@jameskyle