Create .ssh directory when ssh_keypair is set #113#114
Create .ssh directory when ssh_keypair is set #113#114atikhono wants to merge 1 commit intofnichol:masterfrom
Conversation
|
@theckman Could you please have a look? |
|
@atikhono Happy to look. Do you have more information around what failure this resolves? What kind of resource call triggers it? Our test kitchen tests haven't been failing, so it appears we are missing a test case there. Can you please enhance the test kitchen tests to fail if this were to regress? Edit: Sorry for the edit. Along the lines of writing the tests, can you please enhance the commit message to detail what failure this is fixing? When someone runs |
theckman
left a comment
There was a problem hiding this comment.
I'm going to set this to reviewed, with changes requested while waiting on the following:
- more details being added to the initial commit
- tests being added to confirm that this failure mode is fixed
|
Ahem, okay so now I've had some caffeine and noticed #113. Sorry about that! That issue does show the head of the failure itself, which makes sense. I think a test case being written for this PR would solve my inquiry about what kind of resource call triggers it. |
No description provided.