Add Makefile, separate core and development requirements#42
Merged
wangchen615 merged 8 commits intofmperf-project:mainfrom Jul 31, 2025
Merged
Add Makefile, separate core and development requirements#42wangchen615 merged 8 commits intofmperf-project:mainfrom
wangchen615 merged 8 commits intofmperf-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR separates core and development dependencies into distinct requirement files, adds a Makefile to automate common project tasks, and updates the CI to install development requirements.
- Split dependencies into
requirements.txt(core) andrequirements-dev.txt(development). - Introduced a
Makefilewith targets for venv creation, formatting, linting, type-checking, testing, and cleanup. - Updated GitHub Actions workflow to install dev dependencies before running tests.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| requirements-dev.txt | Added development tools: black, mypy, pytest, ruff, and wheel |
| Makefile | New Makefile with targets for setup, format, lint, type-check, test, etc. |
| .github/workflows/unittests.yml | Install requirements-dev.txt in CI before running tests |
Comments suppressed due to low confidence (1)
Makefile:59
- The Makefile uses
--strictfor type checking but the PR description mentions default options; please align the description or adjust the flags for consistency.
mypy --strict ./fmperf
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wangchen615
approved these changes
Jun 10, 2025
wangchen615
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
requirements.txtandrequirements-dev.txtMakefilefor performing common tasksI kept
blackas the linter unchanged, but addedruffas a formatter andmypyas a type checker for consistency with Inference Perf (however, they are running with default options here).