Conversation
mbstadler
left a comment
There was a problem hiding this comment.
This looks great, very nice idea!
Just one thought: At the moment, rows are always averaged. I guess that means there is no way to plot the values for individual reads at the moment (unless reads are non-overlapping). Could there be a use-case where we would want to keep the values without averaging per position?
Otherwise feel free to merge!
|
Thanks! Yes, fair point - perhaps it would be useful to plot also the individual values, I'll look into that. The other thing I was wondering was whether one would like to be able to facet by sample in the function (at the moment one would have to do that by subsetting the SE, creating a plot for each sample and then combining the plots) 🤔 |
|
Yes, I think faceting or coloring by sample might also be a very useful feature, e.g. to directly compare the biases. |
…lable by the user
|
Ok, I've rewritten the function a bit to make the summarization optional and allow facetting by sample. I also limited the application to read-level assays (since for the summary assays we can't necessarily tell the difference between complete inaccessibility and no coverage). |
|
Looks great! You are very productive already on the first day of the year :-) |
Just a suggestion for a convenience function