Skip to content

feat(zs500): initial device support for heat pump#61

Open
JorgenEvens wants to merge 3 commits intoflz:masterfrom
EvensSolutions:feat/zs500
Open

feat(zs500): initial device support for heat pump#61
JorgenEvens wants to merge 3 commits intoflz:masterfrom
EvensSolutions:feat/zs500

Conversation

@JorgenEvens
Copy link
Copy Markdown

This adds support for a Zs500 series heat pump.

The mobile app uses AWS IOT Core to communicate with the heat pump so the code replicates that behaviour.

@flz
Copy link
Copy Markdown
Owner

flz commented Aug 3, 2024

Thank you for the contribution! I'll spend some time reviewing the code when I get a chance but in the meantime, please add unittests similar to those that exist for iaqua.

@flz flz marked this pull request as draft April 1, 2025 17:38
@JorgenEvens JorgenEvens force-pushed the feat/zs500 branch 5 times, most recently from 2040ed1 to ead73d4 Compare May 18, 2025 22:13
@JorgenEvens
Copy link
Copy Markdown
Author

I've implemented the tests. There is a small set of tests that were implemented in the Test Base classes that were not relevant to the implementation using the AWS IOT Core SDK.

@bb3rni
Copy link
Copy Markdown

bb3rni commented Jun 26, 2025

Were the tests successful? What needs to be done to add support for this heat pump?

@bb3rni
Copy link
Copy Markdown

bb3rni commented Jul 1, 2025

Can i test the changed files myself? https://github.com/EvensSolutions/iaqualink-py does not match https://github.com/home-assistant/core/tree/dev/homeassistant/components/iaqualink so how can i import these files into Home Assistant?

@JorgenEvens
Copy link
Copy Markdown
Author

This project is the library used by the iaqualink component in home assistant. They are not the same things, testing it out involves getting an updated version of this library published on or in any other way swapped out in the component.

I prefer to get my changes merged into this library rather than publish another package.

@JorgenEvens JorgenEvens marked this pull request as ready for review September 15, 2025 11:05
@JorgenEvens
Copy link
Copy Markdown
Author

@flz Is there still any interest in this PR?

@JorgenEvens
Copy link
Copy Markdown
Author

I've rebased this PR on the latest master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants