Add heater standby binary sensor for iaqua systems#113
Open
seanonymous wants to merge 3 commits intoflz:masterfrom
Open
Add heater standby binary sensor for iaqua systems#113seanonymous wants to merge 3 commits intoflz:masterfrom
seanonymous wants to merge 3 commits intoflz:masterfrom
Conversation
Add a new read-only binary sensor device for each heater that indicates standby status. The sensor is named {heater_name}_standby (e.g., spa_heater_standby) and reports True when the heater state is "3" (standby mode).
Changes:
- Add IaquaHeaterStandbySensor class that extends IaquaBinarySensor
- Sensor state is computed dynamically by checking the associated heater device state
- Automatically create standby sensors for all heaters in _parse_home_response
- Sensors are automatically included in system.get_devices() results
This allows detection of heater standby state separately from the on/off state, providing more granular status information for integrations like Home Assistant.
Author
|
Hi @flz ! |
Owner
|
Hey, thanks for the submission! I believe this should already be covered as part of the climate entity support in homeassistant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new read-only binary sensor device for each heater that indicates standby status. The sensor is named {heater_name}_standby (e.g., spa_heater_standby) and reports True when the heater state is "3" (standby mode).
Example use case:
User turns on Spa Heater in UI. UI shows heater is on. User goes outside and sees heater is not on. User is confused.
Because Spa Mode is not on and the pool pump is not running, the spa heater is on but it is in standby. User checks UI again, sees 'Spa Heater Standby' is on. User is no longer confused. User turns on pump and the heater fires up and warms the spa.
Changes:
Add IaquaHeaterStandbySensor class that extends IaquaBinarySensor
Sensor state is computed dynamically by checking the associated heater device state
Automatically create standby sensors for all heaters in _parse_home_response
Sensors are automatically included in system.get_devices() results
This allows detection of heater standby state separately from the on/off state, providing more granular status information for integrations like Home Assistant.