Skip to content

FlyteRemote - Delay fetching task execution data until node complete #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wild-endeavor merged 3 commits into from
Nov 3, 2025
Merged

FlyteRemote - Delay fetching task execution data until node complete #3347

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b11e45
don't fetch task execution data if the node is still running
wild-endeavor Nov 3, 2025
bae18bb
breakpoint
wild-endeavor Nov 3, 2025
337a892
remove task phase check now that we added the node level check
wild-endeavor Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2747,8 +2747,11 @@ def sync_node_execution(
# This is the plain ol' task execution case
else:
execution._task_executions = [
# Sync task execution but only get inputs/outputs if the overall execution is done
self.sync_task_execution(
FlyteTaskExecution.promote_from_model(t), node_mapping[node_id].task_node.flyte_task.interface
FlyteTaskExecution.promote_from_model(t),
node_mapping[node_id].task_node.flyte_task.interface,
get_task_exec_data=execution.is_done,
)
for t in iterate_task_executions(self.client, execution.id)
]
Expand All @@ -2763,16 +2766,26 @@ def sync_node_execution(
return execution

def sync_task_execution(
self, execution: FlyteTaskExecution, entity_interface: typing.Optional[TypedInterface] = None
self,
execution: FlyteTaskExecution,
entity_interface: typing.Optional[TypedInterface] = None,
get_task_exec_data: bool = True,
) -> FlyteTaskExecution:
"""Sync a FlyteTaskExecution object with its corresponding remote state."""

execution._closure = self.client.get_task_execution(execution.id).closure
execution_data = self.client.get_task_execution_data(execution.id)
task_id = execution.id.task_id
if entity_interface is None:
entity_definition = self.fetch_task(task_id.project, task_id.domain, task_id.name, task_id.version)
entity_interface = entity_definition.interface
return self._assign_inputs_and_outputs(execution, execution_data, entity_interface)
if get_task_exec_data:
try:
execution_data = self.client.get_task_execution_data(execution.id)
return self._assign_inputs_and_outputs(execution, execution_data, entity_interface)
except Exception as e:
logger.error(f"Failed to get data for successful task execution: {execution.id}, error: {e}")
raise
return execution

#############################
# Terminate Execution State #
Expand Down
Loading