Skip get_node_execution_data if data missing #3344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Contributor
|
Bito Automatic Review Skipped - Draft PR |
wild-endeavor
requested review from
cosmicBboy,
davidmirror-ops,
kumare3,
machichima,
pingsutw and
samhita-alla
as code owners
wild-endeavor
changed the title
pingsutw
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Propeller correctly skips nodes in failure scenarios, and abort scenarios. In these instances, there is no node execution data to pull. Flyte Remote needs to skip these nodes when syncing.
What changes were proposed in this pull request?
Catch the exception raised by the
get_node_execution_dataendpoint.How was this patch tested?
Tested against user's failure scenario.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request introduces a bug fix that enhances the Flyte Remote functionality by adding exception handling for node execution data retrieval. If data is not found, the process will skip the node instead of raising an error, allowing for graceful handling of failure scenarios.