Biscuit integration #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeMOn63
force-pushed
the
biscuit_integration
branch
2 times, most recently
from
b851540 to
cce7101
Compare
daeMOn63
force-pushed
the
biscuit_integration
branch
from
cce7101 to
249a3e9
Compare
Verifiers must now provide the current time for verifying the biscuit, and can extract user informations. User's pubkeys are now provided in http param when exchanging code. Removed block count from biscuit weakening the signature.
…ad of *kmssign.Key
daeMOn63
force-pushed
the
biscuit_integration
branch
from
249a3e9 to
f7f02c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced
AccessTokenBuildertype, responsible of access token generation, with an instance provided at hubauth service creation.Created a
BearerBuilder, which is the default out of the box selected builder, generating the actual oauth signed access tokens.Created a
BiscuitBuilderallowing to generate biscuit access token. It can be enabled by following the readme instructionsAdded a
biscuitpackage, exposing helpers for signed biscuit generation, signature and verification, its aimed to be included in both client and audience applications, so maybe we'll need to move it somewhere else to not embed the full hubauth there.Added a /public-key endpoint, serving the hubauth public key
Modified /token endpoint, to accept an extra b64 encoded public key string parameter
The generated biscuit features: