Add Whisper Display Message Pod #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge PR with issue to Master
# Conflicts: # LibrariesPrototype.xcodeproj/project.pbxproj # LibrariesPrototype/Navigation.swift # LibrariesPrototype/Screens/Main/ViewModels/MainViewModel.swift # Podfile # Podfile.lock # Pods/Manifest.lock # Pods/Pods.xcodeproj/project.pbxproj # Pods/Target Support Files/Alamofire/Alamofire-Info.plist # Pods/Target Support Files/Pods-LibrariesPrototype/Pods-LibrariesPrototype-acknowledgements.markdown # Pods/Target Support Files/Pods-LibrariesPrototype/Pods-LibrariesPrototype-acknowledgements.plist # Pods/Target Support Files/Pods-LibrariesPrototype/Pods-LibrariesPrototype-frameworks.sh # Pods/Target Support Files/Pods-LibrariesPrototype/Pods-LibrariesPrototype.debug.xcconfig # Pods/Target Support Files/Pods-LibrariesPrototype/Pods-LibrariesPrototype.release.xcconfig # Pods/Target Support Files/Pods-LibrariesPrototypeTests/Pods-LibrariesPrototypeTests.debug.xcconfig # Pods/Target Support Files/Pods-LibrariesPrototypeTests/Pods-LibrariesPrototypeTests.release.xcconfig # Pods/Target Support Files/Pods-LibrariesPrototypeUITests/Pods-LibrariesPrototypeUITests.debug.xcconfig # Pods/Target Support Files/Pods-LibrariesPrototypeUITests/Pods-LibrariesPrototypeUITests.release.xcconfig # Pods/Target Support Files/RxCocoa/RxCocoa-Info.plist # Pods/Target Support Files/RxSwift/RxSwift-Info.plist # Pods/Target Support Files/Swinject/Swinject.xcconfig
|
|
||
| import Foundation | ||
|
|
||
| class Session { |
Collaborator
There was a problem hiding this comment.
just a comment, private init looks nice on singleton.
Owner
Author
There was a problem hiding this comment.
like what? Can you please write some here?
Collaborator
There was a problem hiding this comment.
just adding
Suggested change
| class Session { | |
| private init() { | |
| } |
if your class can only be used on ' shared ' variable.
Comment on lines
+36
to
+43
| guard let viewController = Session.shared.currentViewController else { | ||
| return | ||
| } | ||
|
|
||
| // Show and hide a message after delay | ||
| // Whisper.show(whisper: message, to: navigationController, action: .show) | ||
|
|
||
| guard let navigationController = viewController.navigationController else { |
Collaborator
There was a problem hiding this comment.
inline guard with ,
Owner
Author
There was a problem hiding this comment.
You mean like this, right?
Suggested change
| guard let viewController = Session.shared.currentViewController else { | |
| return | |
| } | |
| // Show and hide a message after delay | |
| // Whisper.show(whisper: message, to: navigationController, action: .show) | |
| guard let navigationController = viewController.navigationController else { | |
| guard let navigationController = viewController.navigationController else { return } |
Collaborator
There was a problem hiding this comment.
if we are just checking is it nil.
guard let viewController = Session.shared.currentViewController, let navigationController viewController.navigationController else { return }
Comment on lines
+56
to
+60
| guard let viewController = Session.shared.currentViewController else { | ||
| return | ||
| } | ||
|
|
||
| guard let navigationController = viewController.navigationController else { |
Owner
Author
There was a problem hiding this comment.
You mean like this, right?
Suggested change
| guard let viewController = Session.shared.currentViewController else { | |
| return | |
| } | |
| guard let navigationController = viewController.navigationController else { | |
| guard let navigationController = viewController.navigationController else { return } |
|
|
||
| import UIKit | ||
|
|
||
| enum WhisperMenuCase: Int { |
Collaborator
There was a problem hiding this comment.
as you already know enum auto increment can be used with negative numbers as well.
ogulcankeskin93
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.