Skip to content

refactor(framework): Move exit module to supercore#6984

Draft
panh99 wants to merge 4 commits intomainfrom
codex/move-exit-to-supercore
Draft

refactor(framework): Move exit module to supercore#6984
panh99 wants to merge 4 commits intomainfrom
codex/move-exit-to-supercore

Conversation

@panh99
Copy link
Copy Markdown
Member

@panh99 panh99 commented Apr 9, 2026

Summary

  • move the internal exit package from flwr.common.exit to flwr.supercore.exit
  • update all in-repo imports and moved tests to use the new module path

@panh99 panh99 changed the title [codex] Move exit module to supercore refactor(framework): Move exit module to supercore Apr 9, 2026
@panh99 panh99 marked this pull request as ready for review April 9, 2026 11:13
@panh99 panh99 requested a review from tanertopal as a code owner April 9, 2026 11:13
Copilot AI review requested due to automatic review settings April 9, 2026 11:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR relocates the internal exit helpers from flwr.common.exit to flwr.supercore.exit, aligning ownership with SuperCore runtime components and updating in-repo imports/tests accordingly.

Changes:

  • Moved/introduced flwr.supercore.exit package (exit codes, exit function, exit handlers, signal handling) and corresponding tests.
  • Updated internal imports across SuperLink/SuperNode/ServerApp/Simulation/CLI/compat code to import from flwr.supercore.exit.
  • Adjusted a few tests/mocks/patch paths to the new module location.

Reviewed changes

Copilot reviewed 23 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
framework/py/flwr/supernode/start_client_internal.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supernode/runtime/run_clientapp.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supernode/cli/flwr_clientapp.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supernode/cli/flower_supernode.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/superlink/servicer/control/control_grpc.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supercore/superexec/run_superexec.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supercore/state/alembic/utils.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/supercore/state/alembic/utils_test.py Switch ExitCode import to flwr.supercore.exit.
framework/py/flwr/supercore/inflatable/inflatable_utils.py Switch add_exit_handler import to flwr.supercore.exit.
framework/py/flwr/supercore/exit/init.py New public surface for the relocated exit package.
framework/py/flwr/supercore/exit/exit.py Adjust imports for new package location.
framework/py/flwr/supercore/exit/exit_code.py New/relocated exit codes and help text.
framework/py/flwr/supercore/exit/exit_handler.py New/relocated exit handler registration/execution.
framework/py/flwr/supercore/exit/signal_handler.py New/relocated signal registration helper.
framework/py/flwr/supercore/exit/*_test.py Tests updated/added for relocated exit functionality.
framework/py/flwr/supercore/cli/flower_superexec.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/simulation/run_simulation.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/simulation/app.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/serverapp/exception.py Switch ExitCode import to flwr.supercore.exit.
framework/py/flwr/server/superlink/fleet/rest_rere/rest_api.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/server/serverapp/app.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/server/app.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/compat/server/app.py Switch register_signal_handlers import to flwr.supercore.exit.
framework/py/flwr/compat/client/app.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/client/rest_client/connection.py Switch exit imports to flwr.supercore.exit.
framework/py/flwr/cli/supernode/register.py Switch exit imports to flwr.supercore.exit.
Comments suppressed due to low confidence (1)

framework/py/flwr/supercore/exit/exit.py:35

  • This relative import (from ...common.logger import log) is the only use of a triple-dot relative import to reach flwr.common in the repo; most modules use absolute imports like from flwr.common.logger import log. Consider switching to the absolute import for consistency/readability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Apr 9, 2026
@panh99 panh99 marked this pull request as draft April 9, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants