fix: don't reset desktop notification preference on startup#126
Open
Jord38 wants to merge 1 commit intofluxerapp:canaryfrom
Open
fix: don't reset desktop notification preference on startup#126Jord38 wants to merge 1 commit intofluxerapp:canaryfrom
Jord38 wants to merge 1 commit intofluxerapp:canaryfrom
Conversation
Author
|
Addresses #115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshPermission()inNotificationStoreto only disable notifications when platform permission is revoked, instead of unconditionally setting the valueisGranted()always returnstrue, so the preference was overwritten to "on" every app restartHow to verify
Tests
Checklist
canaryScreenshots / recordings (UI changes)
n/a