Skip to content

Added additional join messages#116

Open
ioletsgo wants to merge 4 commits intofluxerapp:canaryfrom
ioletsgo:canary
Open

Added additional join messages#116
ioletsgo wants to merge 4 commits intofluxerapp:canaryfrom
ioletsgo:canary

Conversation

@ioletsgo
Copy link

Additional join messages are referencing the following properties:
-Black Sabbath's Iron Man
-Futurama
-Harlan Ellison's book I Have No Mouth, and I Must Scream
-Metal Gear Solid 1
-Team Fortress 2
-Metal Gear Solid 3
-Half Life 2.

If I can think up any additional join messages they will also be posted in this pull request.

The additional join messages are from Black Sabbath's Iron Man, Futurama, Harlan Ellison's book I Have No Mouth and I Must Scream, Metal Gear Solid 1, Team Fortress 2, Metal Gear Solid 3, and Half Life 2.
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2026

CLA assistant check
All committers have signed the CLA.

escape character wasn't needed
@ioletsgo
Copy link
Author

Yeah those formatting changes weren't intentional

(username) => i18n._(msg`You've arrived, ${username}! Enjoy the Jigowatt Joyride!`),
(username) => i18n._(msg`${username} Was Turned To Steel, In The Great Magnetic Field!`),
(username) => i18n._(msg`Get comfy ${username}, enjoy a can of Slurm!`),
(username) => i18n._(msg`${username}, HATE. LET ME TELL YOU HOW MUCH I\'VE COME TO HATE YOU SINCE I BEGAN TO LIVE.`),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd actually leave something like this out. This could be misunderstood if you don't get the reference.

Copy link
Author

@ioletsgo ioletsgo Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did actually speak to Hampus regarding concerns about that. The general speech I personally consider to be iconic, but nerds can kinda overestimate the general public's familiarity with certain quotes and references. XKCD 2501 and all that

im nerds btw

Copy link

@gitnickolson gitnickolson Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

Mow that that's gone, I really like these additions :D

Maybe telling the user you hate them in reference to one of the best fictional stories of the 20th century wasn't the smartest idea
@TheKodeToad
Copy link

TheKodeToad commented Feb 27, 2026

Not a maintainer but if you look at the existing messages they explicitly say things hinting towards the fact it's a join message such as "Glad you're here", "Greetings", "Hello", "Welcome" etc. I feel like these messages fit in:

Get comfy ${username}, enjoy a can of Slurm!
Well, ${username}! And about time, too!

(the latter, maybe?)

But the rest don't look like greetings to me who doesn't get most of the references, at least (love the futurama reference though :))

With something like

${username}, Try to remember some of the basics of CQC.

shouldn't you at least put Welcome before it, to be consistent with existing messages like

Welcome, ${username}! Don't forget to park your DeLorean.

(which admittedly are also rather back to the future specific and obviously not everyone would get those references either)

Also calling somebody a spy or a snake could be misinterpreted too, no?

@gitnickolson
Copy link

@TheKodeToad I would agree with you in the latter:

Also calling somebody a spy or a snake could be misinterpreted too, no?

But I think that at least the references that could be easily understood with a quick google search are nothing to be worried about.

That means that I think this one's rather bad:

Welcome ${username}, Try to remember some of the basics of CQC.

But this one is quite okay since you can easily google "DeLorean" and will understand that it's a reference pretty quickly.

Welcome, ${username}! Don't forget to park your DeLorean.

But that's just my opinion and I guess Hampus should decide what's good and what's not

@ioletsgo
Copy link
Author

I do think a general guideline regarding community submitted join messages (or any sort of system messages) would very much be appreciated.

I will definitely have to ask Hampus for something like that, if guidelines are created and some entries don't follow them, I would gladly modify or change them to fit exactly what Hampus has in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants