Add bash shebangs to Justfile recipes#102
Open
Ren6767 wants to merge 1 commit intofluxerapp:canaryfrom
Open
Conversation
On Debian/Ubuntu systems, /bin/sh is actually dash, which does not support set -o pipefail. So when your recipe runs: set -euo pipefail dash errors out with: sh: 1: set: Illegal option -o pipefail Add a bash shebang per recipe will correct the issue and add debian/ubuntu compatibility.
|
|
|
Can confirm that this fixes the issue for me too (arch BTW). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Debian/Ubuntu systems, /bin/sh is actually dash, which does not support set -o pipefail.
So when your recipe runs:
set -euo pipefaildash errors out with:
sh: 1: set: Illegal option -o pipefailAdding a bash shebang per recipe will correct the issue and add debian/ubuntu compatibility. I will also note, it will maintain compatibility with other distros as well.