Add the ability to override the namespace#246
Open
larsmaes wants to merge 10 commits intofluxcd-community:mainfrom
Open
Add the ability to override the namespace#246larsmaes wants to merge 10 commits intofluxcd-community:mainfrom
larsmaes wants to merge 10 commits intofluxcd-community:mainfrom
Conversation
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
|
I am amazed how many headaches the lack of this caused me. Who in their right mind forgot to put a configurable namespace |
|
Normally, the Let's be nice. I'm glad they've opened this PR to add support for this. |
|
@stefanprodan thoughts on merging this? We'd really appreciate it! 🙇🏼♂️ |
Collaborator
|
@larsmaes are you still interested in this pr? If yes, can you please squash and rebase your pr on |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to override the namespace where the flux resources are deployed in. By default it deploys to the release, but now you gain the ability to use it as a sub chart and deploy to its own namespace.
Which issue this PR fixes
fixes #239
Special notes for your reviewer:
Checklist
make reviewable