Skip to content

Add the ability to override the namespace#246

Open
larsmaes wants to merge 10 commits intofluxcd-community:mainfrom
larsmaes:main
Open

Add the ability to override the namespace#246
larsmaes wants to merge 10 commits intofluxcd-community:mainfrom
larsmaes:main

Conversation

@larsmaes
Copy link
Copy Markdown

@larsmaes larsmaes commented Apr 12, 2025

What this PR does / why we need it:

This PR adds the ability to override the namespace where the flux resources are deployed in. By default it deploys to the release, but now you gain the ability to use it as a sub chart and deploy to its own namespace.

Which issue this PR fixes

fixes #239

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • helm-docs are updated
  • Helm chart is tested
  • Update artifacthub.io/changes in Chart.yaml
  • Run make reviewable

Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
Signed-off-by: Lars Maes <lars.maes@gmail.com>
@thereisnotime
Copy link
Copy Markdown

I am amazed how many headaches the lack of this caused me. Who in their right mind forgot to put a configurable namespace

@mattwelke
Copy link
Copy Markdown

@thereisnotime

Normally, the --namespace option lets you set the namespace chart components will be deployed into. This issue only comes up when you use the chart as a subchart.

Let's be nice. I'm glad they've opened this PR to add support for this.

@TylerGillson
Copy link
Copy Markdown

@stefanprodan thoughts on merging this? We'd really appreciate it! 🙇🏼‍♂️

@tamalsaha
Copy link
Copy Markdown
Collaborator

tamalsaha commented Aug 8, 2025

@larsmaes are you still interested in this pr? If yes, can you please squash and rebase your pr on main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support customizing namespace when used as subchart

5 participants