Skip to content

Conversation

@polina-c
Copy link
Collaborator

@polina-c polina-c commented Aug 6, 2025

Contributes to #53

  1. Move spikes/usage_test to examples/minimal_genui
  2. Reference main from USAGE.md

@polina-c polina-c requested a review from gspencergoog August 6, 2025 17:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully moves the usage_test spike to a formal example, minimal_genui, and updates the USAGE.md documentation to reference it. The changes are straightforward and improve the repository's structure. I have a couple of suggestions to further improve maintainability and clarity, one in the documentation and another in a build script.

FLUTTER_PACKAGES=(
"examples/generic_chat"
"examples/travel_app"
"examples/minimal_genui"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and make it easier to find packages, please keep the FLUTTER_PACKAGES array sorted alphabetically. The new entry "examples/minimal_genui" should be placed after "examples/generic_chat".

Copy link
Collaborator

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@polina-c polina-c added autosubmit Created this label with hope that it will magically pick up autosubmit automation from flutter org. current_sprint labels Aug 6, 2025
@polina-c polina-c merged commit e3c3b7c into main Aug 6, 2025
3 checks passed
@polina-c polina-c deleted the usage2 branch August 6, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Created this label with hope that it will magically pick up autosubmit automation from flutter org.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants