Updates the GenuiManager and ConversationWidget structure #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully refactors the GenuiManager and ConversationWidget to remove text-only LLM responses in favor of always using Gen UI. It also introduces a flexible API for custom rendering of chat messages. The changes are well-implemented and include corresponding updates to documentation and tests. My review includes a few suggestions to improve layout stability, logging practices, and code readability.
Comment on lines
434
to
435
| systemInstruction: | ||
| _systemInstruction == null ? null : Content.system(_systemInstruction!), |
Contributor
There was a problem hiding this comment.
This ternary expression to create the systemInstruction is a bit verbose. You can make it more concise and arguably more readable by putting it on a single line.
systemInstruction: _systemInstruction != null ? Content.system(_systemInstruction!) : null,
Collaborator
|
Merging this to avoid conflicts with further PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See updated layout user prompt chat message appearance:
