Move sdk stubs to the spike, that uses it. #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polina-c
requested review from
gspencergoog and
jacobsimionato
and removed request for
gspencergoog
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly moves SDK stubs from the main flutter_genui package to the travel_app_hardcoded spike. This is a good refactoring that improves code organization by decoupling experimental code from the main package. The changes to imports and exports are correct. I have one suggestion to improve the import structure for the new stubs to enhance maintainability. Additionally, please note that the repository's style guide requires pull request descriptions to include the Pre-Review Checklist from the template; the current description is quite brief.
polina-c
changed the title
polina-c
added
the
autosubmit
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes.
Just added instruction for Gemini to skip the folder 'spikes' when reviewing the code.