-
Notifications
You must be signed in to change notification settings - Fork 110
[examples] Verdure client cleanup and dependency updates #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
663ddff
1f2bb5e
0d541f2
f3994cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,7 +33,7 @@ class UploadPhotoScreen extends ConsumerWidget { | |
| ), | ||
| body: SingleChildScrollView( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(16.0), | ||
| padding: const EdgeInsets.all(16), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.stretch, | ||
| children: [ | ||
|
|
@@ -52,7 +52,9 @@ class UploadPhotoScreen extends ConsumerWidget { | |
| ), | ||
| const SizedBox(height: 16), | ||
| Text( | ||
| '''Upload a photo of your front or back yard, and our designers will use it to create a custom vision. Get ready to see the potential.''', | ||
| 'Upload a photo of your front or back yard, ' | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was using triple quotes here because agents seem to have a hard time wrapping these multi-line strings, and triple quotes avoid the lint warning. I'm fine with converting them back, but it does mean more manual work if the LLMs modify the strings, since they will inevitably fail to wrap them properly.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, thanks for the context here and thanks for raising this. I think since this is an example, we should still try to be idiomatic even if it involves a little extra work. I do wonder what we can do to make agents better at breaking strings in general. I find while agents don't handle wrapping/splitting strings well, LLM-based tab/auto-complete handles it quite well across different editors. Perhaps similar examples in the edited file are ending up closer in the context window?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Works for me. It think it's just that they are bad at counting characters. I think they need an edit tool that takes a line range and wraps it, contextually, based on language and context in the code. |
||
| 'and our designers will use it to create a custom vision. ' | ||
| 'Get ready to see the potential.', | ||
| textAlign: TextAlign.center, | ||
| style: Theme.of(context).textTheme.bodyMedium!.copyWith( | ||
| color: Theme.of(context).colorScheme.onSurface, | ||
|
|
@@ -146,34 +148,34 @@ class InfoCard extends StatelessWidget { | |
| child: InkWell( | ||
| onTap: onTap, | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(16.0), | ||
| padding: const EdgeInsets.all(16), | ||
| child: Row( | ||
| mainAxisAlignment: MainAxisAlignment.center, | ||
| crossAxisAlignment: CrossAxisAlignment.center, | ||
| spacing: 16, | ||
| children: [ | ||
| CircleAvatar( | ||
| maxRadius: 25, | ||
| child: Icon(icon, size: 25, color: const Color(0xff15a34a)), | ||
| ), | ||
| if (title != null || subtitle != null) const SizedBox(width: 16), | ||
| if (title != null || subtitle != null) | ||
| Expanded( | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| spacing: 4, | ||
| children: [ | ||
| if (title != null) | ||
| if (title case final title?) | ||
| Text( | ||
| title!, | ||
| title, | ||
| style: Theme.of(context).textTheme.titleMedium! | ||
| .copyWith( | ||
| fontWeight: FontWeight.bold, | ||
| color: Theme.of(context).colorScheme.onSurface, | ||
| ), | ||
| ), | ||
| if (subtitle != null) const SizedBox(height: 4), | ||
| if (subtitle != null) | ||
| if (subtitle case final subtitle?) | ||
| Text( | ||
| subtitle!, | ||
| subtitle, | ||
| style: Theme.of(context).textTheme.bodyMedium! | ||
| .copyWith( | ||
| color: Theme.of(context).colorScheme.onSurface, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ class LoadingState { | |
| } else if (_isProcessingValue && !isProcessing.value) { | ||
| // Went from true to false, reset messages after a short delay | ||
| // to allow the fade-out animation to complete. | ||
| Future.delayed(const Duration(milliseconds: 500), clearMessages); | ||
| Future<void>.delayed(const Duration(milliseconds: 500), clearMessages); | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps we should enable strict-raw-types (https://dart.dev/tools/analysis#enabling-additional-type-checks)? Or is that too much?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm all for it, but since we use a workspace-wide analysis config, I can do that in a follow-up PR for the repository. I enabled it temporarily for verdure and fixed the one other instance of it. |
||
| } | ||
| _isProcessingValue = isProcessing.value; | ||
| }); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.