-
Notifications
You must be signed in to change notification settings - Fork 114
Add structure to code. #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
polina-c
commented
Jul 30, 2025
- Improve CONTRIBUTING.md
- Organize code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the project structure by moving most of the library code into a src directory, which improves organization. The changes also include documentation updates and code formatting. My review focuses on a couple of points: ensuring documentation is suitable for external contributors by removing internal links, and adhering to repository contribution processes. Overall, the restructuring is a positive step for the project's maintainability.
| ## TODO before publishing | ||
|
|
||
| 1. Clean up Google internal information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition for tracking pre-publishing tasks. On a related note about process, the repository's style guide mentions that pull request descriptions should include the Pre-Review Checklist from the PR template. This helps ensure all necessary steps have been completed before review. Please consider updating this PR's description to include the checklist.1
Style Guide References
Footnotes
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import '../model/ui_models.dart'; | ||
| import '../model/chat_message.dart'; | ||
|
|
||
| class ConversationWidget extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an example of a "Custom" widget, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet. Still catching up on the code meaning. Going top down. :)
