Skip to content

feat: Make sure to not add Twig extensions multiple times #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marienfressinaud merged 1 commit into from
Dec 26, 2025
Merged

feat: Make sure to not add Twig extensions multiple times #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Template/Twig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,17 @@ public function render(): string
*/
public static function addExtension(\Twig\Extension\ExtensionInterface $extension): void
{
self::twig()->addExtension($extension);
$twig = self::twig();

if ($extension instanceof \Twig\Extension\AttributeExtension) {
$extension_class = $extension->getClass();
} else {
$extension_class = $extension::class;
}

if (!$twig->hasExtension($extension_class)) {
self::twig()->addExtension($extension);
}
}

/**
Expand Down
4 changes: 0 additions & 4 deletions src/Tests/ApplicationHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ trait ApplicationHelper
#[\PHPUnit\Framework\Attributes\BeforeClass]
public static function loadApplication(): void
{
// This avoids to register extensions multiple times (normally done in
// the Application class constructor) as it would fail.
\Minz\Template\Twig::reset();

$app_name = \Minz\Configuration::$app_name;
$application_class_name = "\\{$app_name}\\Application";
try {
Expand Down