fix: Support IPv6 bind addresses in http_server helper #5239
+87
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes URI::InvalidURIError when binding to IPv6 addresses like '::' or '::1'. The http_server helper was generating invalid URIs such as 'http://:::24231' instead of the RFC 3986 compliant 'http://[::]:24231'. Changes: - Wrap IPv6 addresses in brackets when constructing URIs - Add unit tests for IPv6 localhost (::1) and wildcard (::) binding - Update CHANGELOG.md This bug affected all Fluentd versions including v1.19.1 and caused crashes when attempting to bind HTTP servers to IPv6 addresses in dual-stack environments. Resolves: Invalid URI generation for IPv6 bind addresses Signed-off-by: Jesse Awan <jesse.awan@sap.com>
I501307
force-pushed
the
fix/http-server-ipv6-uri-support
branch
from
a279091 to
eb72e2a
Compare
Author
|
Could a maintainer please add the |
Watson1978
reviewed
Jan 28, 2026
- Updated server.rb to check if IPv6 addresses are already bracketed - Added tests for pre-bracketed addresses ([::1] and [::]) - Improved ipv6_enabled? helper to verify both binding and resolution - Updated CHANGELOG to document pre-bracketed address handling Signed-off-by: Jesse Awan <jesse.awan@sap.com>
Author
|
@Watson1978 Same issue I encountered within a plugin as well here : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes # (if there's an issue, or remove this line)
What this PR does / why we need it:
Fixes URI::InvalidURIError when binding to IPv6 addresses. The http_server
helper was generating invalid URIs like 'http://:::24231' instead of the
RFC 3986 compliant 'http://[::]:24231'.
Release Note:
http_server helper: Fix IPv6 bind address support