plugin_helper/http_server: Ensure request body is closed to prevent socket leaks in POST requests #5231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
http_server
branch
from
c388da5 to
0b8bba9
Compare
Watson1978
added
the
backport to v1.19
Watson1978
changed the title
Watson1978
force-pushed
the
http_server
branch
from
0b8bba9 to
ec897e6
Compare
…ocket leaks in POST requests Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
http_server
branch
from
ec897e6 to
2877337
Compare
Contributor
|
Thanks! |
Contributor
Author
|
Thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 25, 2026
…ocket leaks in POST requests (#5231) **Which issue(s) this PR fixes**: Fixes fluent-plugins-nursery/fluent-plugin-opentelemetry#24 **What this PR does / why we need it**: When using the `http_server` helper to handle POST requests (e.g., in plugins like `fluent-plugin-opentelemetry`), a socket leak occurs, eventually leading to `Errno::EMFILE` (Too many open files). This happens because `Async::HTTP` requires the request body to be fully consumed or explicitly closed to release the resources and allow connection reuse (Keep-Alive). If the body is left unclosed, the socket remains in a CLOSE_WAIT state on the server side indefinitely. **Docs Changes**: N/A **Release Note**: * plugin_helper/http_server: Ensure request body is closed to prevent socket leaks in POST requests Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kenhys
pushed a commit
that referenced
this pull request
Jan 26, 2026
…osed to prevent socket leaks in POST requests (#5231) (#5234) **Which issue(s) this PR fixes**: Backport #5231 Fixes fluent-plugins-nursery/fluent-plugin-opentelemetry#24 **What this PR does / why we need it**: When using the `http_server` helper to handle POST requests (e.g., in plugins like `fluent-plugin-opentelemetry`), a socket leak occurs, eventually leading to `Errno::EMFILE` (Too many open files). This happens because `Async::HTTP` requires the request body to be fully consumed or explicitly closed to release the resources and allow connection reuse (Keep-Alive). If the body is left unclosed, the socket remains in a CLOSE_WAIT state on the server side indefinitely. **Docs Changes**: N/A **Release Note**: * plugin_helper/http_server: Ensure request body is closed to prevent socket leaks in POST requests Signed-off-by: Shizuo Fujita <fujita@clear-code.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shizuo Fujita <fujita@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes fluent-plugins-nursery/fluent-plugin-opentelemetry#24
What this PR does / why we need it:
When using the
http_serverhelper to handle POST requests (e.g., in plugins likefluent-plugin-opentelemetry),a socket leak occurs, eventually leading to
Errno::EMFILE(Too many open files).This happens because
Async::HTTPrequires the request body to be fully consumed or explicitly closed to release the resources and allow connection reuse (Keep-Alive). If the body is left unclosed, the socket remains in a CLOSE_WAIT state on the server side indefinitely.Docs Changes:
N/A
Release Note: