Skip to content

Conversation

@MSallermann
Copy link
Contributor

This PR contains a few small improvements, but mainly the Simulation::steps function has been introduced. In contrast to Simulation::run (which does all steps at once) this function only performs n steps of the simulation (where one step equals the number of lobes deposited on the topography).
From the point of view of the CLI application this is of course useless, but it enables granular control over the parameters during a run, when performing simulations with pyflowy.
The use pattern looks something like this

    while simulation.steps(100) == pfy.flowycpp.RunStatus.Ongoing:
        simulation.input.max_slope_prob += 0.1
        # ... more parameter changes etc.

MSallermann and others added 13 commits March 26, 2025 15:24
Co-authored-by: Amrita Goswami <amritagos@users.noreply.github.com>
a bit more concise

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
ENH: simulation: better const correctness :)

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
moved some functional units into new class methods

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
simulation: implement `run` in terms of `steps`
In pyflowy we can then fetch it from the flowy subproject with
get_variable.

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
Got some errors with clang...

Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
@MSallermann MSallermann requested a review from amritagos as a code owner March 27, 2025 22:16
MSallermann and others added 2 commits March 27, 2025 22:18
Co-authored-by: Amrita Goswami <amrita16thaug646@gmail.com>
provision-with-micromamba has been deprecated
@MSallermann MSallermann merged commit e15e0ea into main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants