configure.ac: fix res_ninit detection
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowerysong
force-pushed
the
res_ninit
branch
2 times, most recently
from
8806acb to
c928cd6
Compare
For what I'm sure are very good reasons, libc implementations like to export the symbol as `__res_ninit` and have `res_ninit` as a `#define`. https://sourceware.org/git/?p=glibc.git;a=blob;f=resolv/resolv.h;h=b8a0f66a;hb=HEAD#l228 This means a naive check for the symbol always fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For what I'm sure are very good reasons, libc implementations like to export the symbol as
__res_ninitand haveres_ninitas a#define.https://sourceware.org/git/?p=glibc.git;a=blob;f=resolv/resolv.h;h=b8a0f66a;hb=HEAD#l228
This means a naive check for the symbol always fails.
I've tested this replacement check on Rocky Linux 9, FreeBSD 14, and Alpine (musl does not implement
res_ninit), but I'd kind of like to find somewhere where an additional library is actually necessary to have complete confidence in it...