FDN-4269: migrate all flowdocker images to ECR/flowcommerce

[Prashant2976]

Bulk migration away from flowdocker to ECR/flowcommerce

Summary by CodeRabbit

• Chores
  • Updated Docker base images to private registry-hosted versions for improved security and compatibility.
  • Added a container healthcheck that verifies application readiness via the service readiness endpoint, improving automated monitoring and faster failure detection.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Replaced two Dockerfile base images with AWS ECR equivalents and added a HEALTHCHECK that curls the application's internal readiness endpoint. No other build steps or exported/public declarations changed.

Changes

Cohort / File(s)	Summary
Docker Configuration Dockerfile	Replaced base images: builder stage from flowdocker/play_builder:latest-java17-noble → 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_builder_java17_noble:latest; runtime stage from flowdocker/play:latest-java17 → 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_java17:latest. Added HEALTHCHECK that curls the internal readiness path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• FDN-4269: migrate all flowdocker images to ECR/flowcommerce #651: Modifies the same Dockerfile base image lines, migrating flowdocker/... to the ECR flowcommerce images.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: migrating flowdocker base images to ECR/flowcommerce in the Dockerfile.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between daeb6d9 and 2733940.

📒 Files selected for processing (1)

• Dockerfile

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dockerfile (1)

2-2: Consider using COPY instead of ADD.

The static analysis tool flags this line because ADD has implicit behavior (tar auto-extraction, URL support) that isn't needed here. COPY is more explicit and is the recommended practice for simple file/directory operations.

♻️ Proposed fix

-ADD . /opt/play
+COPY . /opt/play

Based on static analysis hints from Hadolint.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6bcd45f and daeb6d9.

📒 Files selected for processing (1)

• Dockerfile

🧰 Additional context used

🪛 Hadolint (2.14.0)

Dockerfile

[error] 2-2: Use COPY instead of ADD for files and folders

(DL3020)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Jenkins

🔇 Additional comments (1)

Dockerfile (1)

1-1: Pin ECR image tags to specific versions instead of :latest.

Using :latest tags can lead to non-reproducible builds—different builds at different times may pull different image versions. Pin both base images to specific version tags or SHA256 digests:

-FROM 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_builder_java17_noble:latest as builder
+FROM 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_builder_java17_noble:<version-tag> as builder

-FROM 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_java17:latest
+FROM 479720515435.dkr.ecr.us-east-1.amazonaws.com/flowcommerce/play_java17:<version-tag>

Verify that both images exist in the ECR repository and are accessible via your CI/CD authentication before merging.

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/registry/job/PR-651/1/scoverage-report/

[flow-tech]

Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/registry/job/PR-651/2/scoverage-report/