Enable model predictions in output transform space#63
Open
epaillas wants to merge 8 commits intoflorpi:mainfrom
Open
Enable model predictions in output transform space#63epaillas wants to merge 8 commits intoflorpi:mainfrom
epaillas wants to merge 8 commits intoflorpi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some emulators are trained using data transformations (log, asinh, etc) to improve performance. We normally apply the inverse transform during parameter inference, so the likelihood is always computed in the original, untransformed space. Nathan is currently testing if this could induce biases.
This PR adds some additional flexibility to sunbird to handle posterior sampling in the transformed space. Also slided in some other small things from previous edits that I hadn't commited.