Refactor dict merging using ChainMap#11
Open
StrideZhou wants to merge 2 commits intoflorianmahner:mainfrom
Open
Refactor dict merging using ChainMap#11StrideZhou wants to merge 2 commits intoflorianmahner:mainfrom
StrideZhou wants to merge 2 commits intoflorianmahner:mainfrom
Conversation
Replaced dictionary unpacking ({**dict1, **dict2}) with collections.ChainMap for merging dicts. This change affects the _extract_base_defaults and add_arguments_from_toml methods, improving performance and preserving original data structures. It also allows more flexible handling of configuration overrides and inheritance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 2 2
Lines 80 81 +1
Branches 13 13
=======================================
+ Hits 80 81 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
thank you - this indeed looks like a good contribution. some type checks are still failing (eg also returning ChainMap as type). could you make these adjustments? then i am happy to merge once the checks are passing |
fix return type error: dict[str, Any] -> ChainMap[str, Any]
Owner
|
please see Contributing.md to check how you can test in advance. Happy to accept once tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced dictionary unpacking ({**dict1, **dict2}) with collections.ChainMap for merging dicts. This change affects the _extract_base_defaults and add_arguments_from_toml methods, improving performance and preserving original data structures. It also allows more flexible handling of configuration overrides and inheritance.