@Florian => Fix the example app, fixes #17 #39 #33#47
Open
Conversation
Contributor
|
You should probably use a |
Collaborator
Author
|
Ah yes, this makes sense. |
Collaborator
Author
|
Hrm, I thought I understood this, but it seems I don't - @alloy any chance you can take a look at fixing this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll save this one for a patch release, and get 1.0.0 out - so this isn't blocking.
I'm interested in the ramifications here:
It seems reasonable to think when FLKAutoLayout was written Auto Layout would accept a multiplier of
0in constraints - but since then, maybe since iOS8? The API does not allow using a 0 as the multiplier - which causes crashes in the example app, and assumably in all of the app code ( I don't see any uses ofdistributeCenterXOfViewsor the others in Eigen, I expect because of this. )Can you think of a better way to do this, and/or do you think this would cause issues?
/cc @alloy if you want to have a think too