Dev #3
Open
Dev #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppyzedolfin
force-pushed
the
dev
branch
5 times, most recently
from
4683ab5 to
8e03855
Compare
floppyzedolfin
commented
Feb 28, 2021
internal/square/square.go
Outdated
|
|
||
| // Square squares the value contained in the request | ||
| func Square(_ fiber.Ctx, req squaredef.Request) (squaredef.Response, *fiber.Error) { | ||
| if err := req.Validate(); err != nil { |
Owner
Author
There was a problem hiding this comment.
I'd like to move the Validate() to the upper layer (squareWrapper), but then I'd have *req.Value with no explicit check in here.
alienorlatour
left a comment
alienorlatour
left a comment
There was a problem hiding this comment.
Some _test files were left unread.
|
|
||
| var ( | ||
| // default parameters - they aren't exposed and can't be changed by the rest of the world, but, in order to properly test this, I can't have hardwritten consts | ||
| defaultLevel = Debug // change this to change the logging threshold |
There was a problem hiding this comment.
This could be changed by a parameter to the service.
floppyzedolfin
force-pushed
the
dev
branch
4 times, most recently
from
cc1ddb5 to
46da94d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.