modified second figure visualization for "FAIR" metrics#7
Open
lukakeso wants to merge 2 commits intoflopezag:masterfrom
Open
modified second figure visualization for "FAIR" metrics#7lukakeso wants to merge 2 commits intoflopezag:masterfrom
lukakeso wants to merge 2 commits intoflopezag:masterfrom
Conversation
Collaborator
lukakeso
commented
Aug 5, 2025
lukakeso
commented
- added labels for FAIRness levels
- added dotted lines for each FAIRness level
- added white ticks for each FAIRness level
- added bias term (to adjust for 0.5 shift)
- adjusted legend display for FAIR visualization
flopezag
requested changes
Aug 5, 2025
analysis/graphics.py
Outdated
| x1, y1 = [x1[i] + inc_x[i] for i in range(len(x1))], [y, y] | ||
| if model_type == "FAIR": | ||
| # Add white lines at the top of each division within the column | ||
| y = (num_divisions - 1) + 0.5 - 0.02 # the lines have linewidth=3, so to center the line we need to rest 0.01 |
Owner
There was a problem hiding this comment.
Maybe we should consider to change the comment here.
| temp_y2 = list() | ||
|
|
||
| if model_type == "FAIR": | ||
| bias = 0.5 |
Owner
There was a problem hiding this comment.
please provide some description in order to prevent the MAGIC NUMBERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.