Skip to content

Fix SAWarning in lambda_stmt test #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flipbit03 merged 1 commit into from
Jan 26, 2026
Merged

Fix SAWarning in lambda_stmt test #41

flipbit03 merged 1 commit into from
Jan 26, 2026

Conversation

@flipbit03
Copy link
Owner

@flipbit03 flipbit03 commented Jan 26, 2026

Summary

  • Replace subqueryload with selectinload in test_lambda_stmt_with_subqueryload test
  • Rename test to test_lambda_stmt_with_selectinload_multiple_children to avoid duplicate names

Why

SQLAlchemy emits a warning when using subqueryload with lambda_stmt:

SAWarning: subqueryloader for "SDParent.children" must invoke lambda callable... Consider using selectinload() for more effective full-lambda caching

This is because subqueryload doesn't cache efficiently with lambda statements.

Test plan

  • All tests pass
  • Lint passes (make lint)
  • Type check passes (make typecheck)
  • No SAWarning when running with -W error::sqlalchemy.exc.SAWarning

@flipbit03
Fix SAWarning in lambda_stmt test by using selectinload instead of su…
c2b00b0 
…bqueryload

subqueryload has caching issues with lambda_stmt, causing SQLAlchemy to emit
a warning recommending selectinload for more effective full-lambda caching.
@flipbit03 flipbit03 merged commit cc3d338 into main Jan 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flipbit03