Open
Conversation
Author
|
@flip-dots feel free to add comments for things I should change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the new effects like candle and fireplace flickering.
Those were introduced with a firmware update to existing bulbs.
The new firmware introduced a new BLE characteristic which is described in the following issue:
#4
In general the new characteristic can do what the old ones can already accomplish. So it is debatable if it is good to switch to it entirely. For compatibility reason I just added it for the new effects. The advantage of the new characteristic is that one can change brightness, color, effects,etc with one command together.