-
Notifications
You must be signed in to change notification settings - Fork 17
Viewing canceling/canceled image builds and exports #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds "Canceling" and "Canceled" condition reasons and migrates UI and utilities from boolean status predicates to enum-based status reasons for image build/export flows. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@libs/ui-components/src/components/ImageBuilds/ImageBuildDetails/ImageBuildLogsTab.tsx`:
- Around line 59-82: The status handling in ImageBuildAndExportLogStatus
incorrectly only checks ImageBuildConditionReason and collapses export statuses
and Canceling into wrong labels; update the conditional logic to also check
ImageExportConditionReason equivalents (e.g.,
ImageExportConditionReason.ImageExportConditionReasonCompleted, ...Failed,
...Canceling, ...Canceled) or normalize by matching both enums' values, and map
Canceling -> level 'warning' with label t('Canceling') and Canceled -> level
'warning' with label t('Canceled'), while keeping Completed ->
'success'/'Completed', Failed -> 'danger'/'Failed', and default -> 'info'/'In
progress'; reference the ImageBuildAndExportLogStatus component and the status
prop, plus the ImageBuildConditionReason and ImageExportConditionReason symbols
when making the changes.
🧹 Nitpick comments (1)
libs/ui-components/src/components/ImageBuilds/ImageBuildRow.tsx (1)
110-129: Consider adding UI feedback for Canceled builds.The failure block is only shown when
buildReason === ImageBuildConditionReasonFailed. With the new Canceled state, users might benefit from similar visual feedback indicating that the build was canceled. This could help distinguish between builds that failed due to errors vs. those that were intentionally canceled.This is a minor suggestion and can be deferred to a follow-up since the PR description mentions that cancellation actions will be implemented after UX discussion.
libs/ui-components/src/components/ImageBuilds/ImageBuildDetails/ImageBuildLogsTab.tsx
Show resolved
Hide resolved
496a1d2 to
a0d79a3
Compare
Displays the new Canceled/Canceling statuses for Image Builds and Image Exports.
To be done as a follow-up, to add the actions to cancel the (needs UX discussion).
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.