Skip to content

Fix memory leak in build_param_array #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benburwell merged 4 commits into from
Apr 24, 2025
Merged

Fix memory leak in build_param_array #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67dab74
Fix memory leak in build_param_array
benburwell Apr 21, 2025
a3384f9
Bump version number to 3.1.1
benburwell Apr 21, 2025
29ebf8b
Use tcl-tk@8 for macOS CI
benburwell Apr 21, 2025
d8fd256
Fix an additional memory leak in expand_parameters
benburwell Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/mac-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:
- name: Install dependencies
run: |
brew update
brew install tcl-tk autoconf libpq
brew install tcl-tk@8 autoconf libpq
- name: configure
run: |
autoreconf -vi
export PG_CONFIG=/opt/homebrew/opt/libpq/bin/pg_config
./configure --with-tcl=/opt/homebrew/opt/tcl-tk/lib/ --prefix=/usr/local
./configure --with-tcl=/opt/homebrew/opt/tcl-tk@8/lib/ --prefix=/usr/local
- name: make
run: make
- name: install
Expand Down
2 changes: 1 addition & 1 deletion configure.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dnl to configure the system for the local environment.
# so you can encode the package version directly into the source files.
#-----------------------------------------------------------------------

AC_INIT([pgtcl], [3.1.0])
AC_INIT([pgtcl], [3.1.1])

#-----
# Version with patch stripped
Expand Down
2 changes: 2 additions & 0 deletions generic/pgtclCmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,7 @@ int build_param_array(Tcl_Interp *interp, int nParams, Tcl_Obj *CONST objv[], co
}

*paramValuesPtr = paramValues;
ckfree(paramLengths);

return TCL_OK;
}
Expand Down Expand Up @@ -2927,6 +2928,7 @@ static int expand_parameters(Tcl_Interp *interp, const char *queryString, int nP
// Normal return, push parameters and return OK.
*paramValuesPtr = paramValues;
*newQueryStringPtr = newQueryString;
ckfree(paramLengths);
return TCL_OK;

error_return:
Expand Down
Loading