fix unreachable panic when parsing export table #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this issue when fuzzing the crate. The export symbol flag kind uses that last two bits of `flags`, and therefore can take 4 values. Only 3 officially defined in the ExportSymbolKind enum. Malformed macho files can define a symbol kind of 0b11 and will cause this crate to panic when parsing them. Avoid panicking, and return a new error kind instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue when fuzzing the crate.
The export symbol flag kind uses that last two bits of
flags, and therefore can take 4 values. Only 3 are officially defined in theExportSymbolKindenum.Malformed macho files can define a symbol kind of 0b11 and will cause this crate to panic when parsing them.
Avoid panicking, and return a new error kind instead.