Fix two compilation errors on i686-w64-mingw32 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument len is size_t, not ulong. Fix the following error on i686-w64-mingw32: compile_v52.go:40:73: cannot use _Ctype_ulong(len(expression)) (value of type _Ctype_ulong) as type _Ctype_uint in variable declaration
starius
force-pushed
the
fixes-for-mxe
branch
from
6b2bbdd to
5354263
Compare
Use unsafe.Slice instead of using a type of array of size 1 << 30. Fix error on i686-w64-mingw32: compile.go:407:30: type [1073741824]*_Ctype_char larger than address space
|
@flier please review and approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these two fixes, I managed to build
simplegrep.exefor Windows using i686-w64-mingw32 (cross-compilation from Linux).