This repository was archived by the owner on Dec 24, 2025. It is now read-only.
fix(docs): update #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes and updates the documentation infrastructure and improves code quality across the flet_map package. The changes modernize type annotations, enhance documentation tooling, and fix various issues in the codebase.
- Updates type annotations from legacy Python style to modern syntax (e.g.,
List[T]→list[T]) - Modernizes documentation configuration with better tooling and validation
- Fixes various documentation references and formatting issues throughout the codebase
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/flutter/flet_map/pubspec.yaml | Updates flutter_lints dependency from ^2.0.0 to ^3.0.0 |
| src/flet_map/types.py | Modernizes type annotations, fixes docstring formatting, and improves error messages |
| src/flet_map/tile_layer.py | Updates type annotations and improves assertion error messages |
| src/flet_map/source_attribution.py | Modernizes type annotations and fixes docstring formatting |
| src/flet_map/simple_attribution.py | Updates type annotations and fixes alignment reference |
| src/flet_map/rich_attribution.py | Updates type annotations and improves docstring formatting |
| src/flet_map/polyline_layer.py | Updates type annotations and improves assertion error messages |
| src/flet_map/polygon_layer.py | Updates type annotations and improves assertion error messages |
| src/flet_map/marker_layer.py | Updates type annotations and improves assertion error messages |
| src/flet_map/map.py | Updates type annotations, improves docstring formatting, and fixes method calls |
| src/flet_map/circle_layer.py | Updates type annotations and improves assertion error messages |
| src/flet_map/init.py | Adds comprehensive all list for proper module exports |
| pyproject.toml | Updates documentation and development dependencies with version constraints |
| mkdocs.yml | Modernizes documentation configuration with new plugins and settings |
| docs/types/*.md | Adds separate_signature: false option to enum documentation |
| .pre-commit-config.yaml | Updates pre-commit hooks to use ruff instead of isort/black |
| .github/workflows/docs.yml | Updates documentation workflow to include dev branch and lint group |
Comment on lines
35
to
+36
| "TileDisplay", | ||
| "InstantaneousTileDisplay", | ||
| "FadeInTileDisplay", | ||
| "KeyboardConfiguration", | ||
| "CursorRotationBehaviour", | ||
| "CursorKeyboardRotationConfiguration", | ||
| "TileLayerEvictErrorTileStrategy", |
There was a problem hiding this comment.
The all list is being alphabetically sorted, but "TileLayerEvictErrorTileStrategy" appears at the end instead of its alphabetical position. It should be placed after "StrokePattern" and before the end to maintain consistent alphabetical ordering.
FeodorFitsner
approved these changes
Jul 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.