Skip to content

Conversation

@KanishkKhurana
Copy link
Contributor

Why?

minor port fix based on discussion

How?

remove DHT port and add pinger port

Copy link
Contributor

@matthias-wright matthias-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthias-wright
Copy link
Contributor

just realized the title says rpc port, but the rpc port wasn't changed. were you planning on changing the rpc port to the current testnet port?

@KanishkKhurana
Copy link
Contributor Author

just realized the title says rpc port, but the rpc port wasn't changed. were you planning on changing the rpc port to the current testnet port?

Thanks for pointing that out. I have added the change here

Copy link
Contributor

@matthias-wright matthias-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KanishkKhurana KanishkKhurana merged commit adae696 into develop Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants