Skip to content

Conversation

@amantoux
Copy link
Member

@amantoux amantoux commented Sep 21, 2025

Introduce a new API for embeds.

This change simplifies the configuration of SpanEmbeds & BlockEmbeds

Embeds must be registered in an EmbedRegistry that needs to be passed to the editor

@amantoux amantoux marked this pull request as draft September 21, 2025 15:04
@amantoux amantoux force-pushed the span_embed_configuration branch from e36df66 to 6fcf3e5 Compare September 21, 2025 15:09
@amantoux amantoux requested a review from Amir-P September 21, 2025 15:09
@codecov
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.29%. Comparing base (61a029f) to head (dcfdec3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   89.30%   89.29%   -0.02%     
==========================================
  Files          63       64       +1     
  Lines       10990    11039      +49     
==========================================
+ Hits         9815     9857      +42     
- Misses       1175     1182       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amantoux amantoux force-pushed the span_embed_configuration branch 4 times, most recently from f63f5b9 to a1396b0 Compare September 22, 2025 13:46
@amantoux amantoux force-pushed the span_embed_configuration branch from a1396b0 to 7ec9ee2 Compare September 25, 2025 07:17
@amantoux amantoux changed the title SpanEmbed configuration New Embed API Sep 26, 2025
@amantoux amantoux force-pushed the span_embed_configuration branch from 6c9e2eb to 5bb88ca Compare September 30, 2025 16:50
@amantoux amantoux marked this pull request as ready for review September 30, 2025 16:50
@amantoux amantoux force-pushed the span_embed_configuration branch 3 times, most recently from a907829 to 4e8f503 Compare October 1, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants