Skip to content

fix-for-reusing-enum-references#118

Closed
ajayrathore wants to merge 1 commit intoflavray:masterfrom
ajayrathore:fix-for-reusing-enum-references
Closed

fix-for-reusing-enum-references#118
ajayrathore wants to merge 1 commit intoflavray:masterfrom
ajayrathore:fix-for-reusing-enum-references

Conversation

@ajayrathore
Copy link

Hi,

I fixed the issue raised by me earlier, the fix is to be able to process following schema type

{
  "type": "record",
  "name": "mymsg",
  "namespace": "myns",
  "fields": [
    {
      "name": "myid",
      "type": "int"
    },
    {
      "name": "c1",
      "type": {
        "type": "enum",
        "name": "myflag",
        "symbols": [
          "A",
          "B",
          "C"
        ]
      }
    },
    {
      "name": "c2",
      "type": "myflag"
    }
  ]
}

@poros
Copy link
Collaborator

poros commented Apr 11, 2020

This is a sub-case of what PRs like #53 and #99 tried to implement. I'd rather implement the whole thing than add a very partial "patch" like this one, sorry.
But thanks for being so pro-active and for contributing! :)

@ajayrathore
Copy link
Author

That's fine, I needed this particular fix urgently for a project I am working on, I will keep using my fix locally and take your changes once released.

Thanks

@poros poros closed this Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants