Conversation
Removed bypassSecurityTrustHtml for user-provided templates, its totally unsafe to use it. Fixed class for html inserted via innerHTML (from sn-content to sn-html)
|
@flauc Hello, build failed but I believe the cause is not in the PR, please take a look. |
|
@flauc Could you please review this PR it's really holding me back. |
|
Hi @WiseBird, I'm sorry this is taking so long I'm very short on time recently. Will do my best to have it merged tonight. |
|
#deadproject |
|
Feel free to look into the issue @worthy7. Project is clearly not dead since owner just released v1.0.0 to fix a bug. He's doing this for free. |
|
True, I am thankful! |
|
I am also looking forward to see this PR merged :) @WiseBird Please merge/rebase and push in order to have the failed checks gone.. |
|
Any news on this feature? I need this pretty badly... |
|
This library looks nice and appreciate the effort that went into it but now we're after TemplateContexts we've got to transition to ngx-toastr. Maybe it would be better for us all to focus our efforts on ngx-toastr (which even has ng7 support already) and add a deprecation notice on this project that points there? |
|
@flauc Any update on this feature/Pull request? I need this pretty badly... |
@WiseBird do ngx-toastr have template context feature? |
|
@wsh92 Yes, but it uses different approach: you create custom component for notification and pass there any data you like. |
|
@WiseBird Thanks, it is working like charm:) |
9 participants
Added a way to pass arbitrary data to templates.
Removed bypassSecurityTrustHtml for user-provided templates, its totally unsafe to use it.
Fixed class for html inserted via innerHTML (from sn-content to sn-html).