Remove 500ms setTimeout for the window.onpopstate assignment. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old Chrome bug has been reported to be fixed. http://code.google.com/p/chromium/issues/detail?id=63040 Initial testings in my app using this lib shows the route handlers aren't called twice on initial page load and after hard refreshes.
|
So what about this PR? Are you planning to do any movement on this? With this 500 ms fix I get |
|
Is there anything I can do to help this get merged -- this is blocking us |
|
Also note that this fix causes bug #227 to happen pretty consistently on iOS devices. For that and other reasons I'm switching my project to |
|
@cmwelsh Yep, noticed that yesterday. We switched to react-router yesterday. It's still a new project so it was pretty easy. |
SpaceK33z
added a commit
to CodeYellowBV/tarantino
that referenced
this pull request
Dec 1, 2016
|
For anyone bumping into this, I've fixed this in my fork, published it on npm and plan to maintain it (with that I mean, I will review PR's and fix critical issues). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Chrome bug has been reported to be fixed.
http://code.google.com/p/chromium/issues/detail?id=63040
Initial testings in my app using this lib show that the route handlers aren't called twice on initial page load and after hard refreshes after this change.