Skip to content

Remove DConf Hole#54

Draft
A6GibKm wants to merge 1 commit intoflathub:masterfrom
A6GibKm:master
Draft

Remove DConf Hole#54
A6GibKm wants to merge 1 commit intoflathub:masterfrom
A6GibKm:master

Conversation

@A6GibKm
Copy link
Contributor

@A6GibKm A6GibKm commented Oct 9, 2020

Unlike the prior PR #47, this adds the proper path for the gschema. Fixes #45.

Had to use 3.38.0 as 3.38.1 would not compile due to the Tracker1 to Tracker3 migration.

Tested:

  • First login appears only on first run
  • Window size is maintained
  • Create a Fedora 32 box
  • Enter said box

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 9, 2020

If merged, please consider applying this changes upstream.

@flathubbot
Copy link
Contributor

Started test build 29913

@flathubbot
Copy link
Contributor

Build 29913 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28805/org.gnome.Boxes.flatpakref

@A6GibKm A6GibKm changed the title Delete DConf Hole Remove DConf Hole Oct 9, 2020
@A6GibKm A6GibKm marked this pull request as draft October 9, 2020 21:45
@A6GibKm A6GibKm mentioned this pull request Oct 9, 2020
@A6GibKm A6GibKm marked this pull request as ready for review October 10, 2020 07:40
@Eonfge
Copy link

Eonfge commented Oct 11, 2020

@bilelmoussaoui Relevant after updating to 3.38. It will also provide the new tracker which is nice

@felipeborges
Copy link
Collaborator

Could you please drop commit eb92c1f from this PR?

Thank you very much.

@flathubbot
Copy link
Contributor

Started test build 30675

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 19, 2020

Sorry about that, done. I am pretty sure this won't build, maybe it should be rebased on top of the 3.38.1 PR?

@flathubbot
Copy link
Contributor

Build 30675 failed

@flathubbot
Copy link
Contributor

Started test build 30836

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 22, 2020

Rebased.

@flathubbot
Copy link
Contributor

Build 30836 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/29707/org.gnome.Boxes.flatpakref

@felipeborges
Copy link
Collaborator

Now I am debugging why GSettings/GLib won't pick up org.gnome.desktop.input-sources used by Boxes[0] throughout the Flatpak Settings portal.

Back when the dconf keyfile migration was starting to happen, I proposed [1] and [2]. So GLib should be able to pick it up from the portal automagically. :)

Unfortunately, that doesn't seem to be working for Boxes.

To verify, you need to compare the output of the command below in the host:

  1. gsettings get org.gnome.desktop.input-sources sources

With the output of the same command within the app's sandbox:

  1. flatpak --command=bash run org.gnome.Boxes//test
  2. gsettings get org.gnome.desktop.input-sources sources

In my system, the sources list returned inside the sandbox is empty. It should be identical to what you get on the host.

Btw, this is similar to when I got this PR #47.

[0] https://gitlab.gnome.org/GNOME/gnome-boxes/blob/master/src/unattended-installer.vala#L670
[1] flatpak/xdg-desktop-portal#367
[2] flatpak/xdg-desktop-portal-gtk#232

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Oct 23, 2020

Thanks for the precise information, you are right. I am getting

@a(ss) []

Inside the sandbox, which is certainly different than

[('xkb', 'us+altgr-intl')]

@A6GibKm
Copy link
Contributor Author

A6GibKm commented Jul 12, 2024

See flathub/flathub#1040, this is not allowed by the flathub linter anymore. If this is still an issue we might need to request an exception.

@bbhtt
Copy link

bbhtt commented Jul 17, 2024

All existing ones already got exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old DConf access method

5 participants