Patch: Do not use named icons for StatusNotifierItem#173
Open
picsel2 wants to merge 1 commit intoflathub:masterfrom
Open
Patch: Do not use named icons for StatusNotifierItem#173picsel2 wants to merge 1 commit intoflathub:masterfrom
picsel2 wants to merge 1 commit intoflathub:masterfrom
Conversation
Contributor
|
Started test build 142677 |
Contributor
|
Build 142677 failed |
Contributor
|
Started test build 147392 |
Contributor
|
Build 147392 successful |
tilosp
reviewed
Sep 17, 2024
Collaborator
tilosp
left a comment
tilosp
left a comment
There was a problem hiding this comment.
to me this looks like it will affect all icons, not only the systray icon.
This is an ugly workaround for flathub#21. It prevents passing an icon name over DBus to the host environment where the theme is not known. Instead it enforces the use of the PixMap.
picsel2
force-pushed
the
tray-icon-workaround
branch
from
246d9e8 to
6f59ab4
Compare
Contributor
|
Started test build 151764 |
Contributor
|
Build 151764 successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an ugly workaround for #21. It prevents passing an icon name over DBus to the host environment where the theme is not known. Instead it enforces the use of the PixMap.