docs: Clarify that http_proxy is not used for HTTPS requests#475
Merged
t-lo merged 3 commits intoflatcar:mainfrom Mar 4, 2026
Merged
docs: Clarify that http_proxy is not used for HTTPS requests#475t-lo merged 3 commits intoflatcar:mainfrom
t-lo merged 3 commits intoflatcar:mainfrom
Conversation
pothos
reviewed
Sep 10, 2025
Contributor
Author
Oh, missed that. Just updated my PR.
I’ll look into this, too. |
pothos
approved these changes
Sep 23, 2025
Member
pothos
left a comment
There was a problem hiding this comment.
Thanks, looks good, I wonder if we should wait until this is also merged upstream (Butane and Ignition repos) or it might get overwritten once we need to sync a newer version of the specs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update documentation: Clarify that http_proxy is not used for HTTPS requests
While experimenting with proxy settings in a Butane config, I noticed that
https_proxymust be explicitly set for HTTPS requests to go through the proxy. Setting onlyhttp_proxywill proxy plain HTTP requests, but HTTPS requests still go out directly.However, the documentation previously stated that
http_proxywould also be used for HTTPS requests unless overridden byhttps_proxy. This is incorrect, as confirmed on Matrix.This PR updates the documentation to reflect the actual behavior.